From 0b4044f26776ce2b3352bbd7f38adc1b9a258697 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Ne=C4=8Dada?= Date: Sun, 6 May 2018 21:29:02 +0000 Subject: [PATCH] Fix translation coefficient magnitude for unnormalized waves. N. B. this will lead to different numbers than in Xu's tables. The normalizations "XU" and "NONE" will be hence different Former-commit-id: 040a39c694e871b487523af73abbf3028ef81576 --- qpms/translations.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/qpms/translations.c b/qpms/translations.c index f79f00a..37bf595 100644 --- a/qpms/translations.c +++ b/qpms/translations.c @@ -137,9 +137,14 @@ static inline double qpms_trans_normlogfac(qpms_normalisation_t norm, case QPMS_NORMALISATION_TAYLOR: return -0.5*(lgamma(n+m+1)-lgamma(n-m+1)+lgamma(nu-mu+1)-lgamma(nu+mu+1)); break; + case QPMS_NORMALISATION_NONE: + return -(lgamma(n+m+1)-lgamma(n-m+1)+lgamma(nu-mu+1)-lgamma(nu+mu+1)); + break; + /* // TODO NONE and XU are going to be different after all... case QPMS_NORMALISATION_XU: return 0; break; + */ default: abort(); } @@ -158,8 +163,13 @@ static inline double qpms_trans_normfac(qpms_normalisation_t norm, case QPMS_NORMALISATION_TAYLOR: normfac *= sqrt((2.*n+1)/(2.*nu+1)); break; + case QPMS_NORMALISATION_NONE: + normfac *= (2.*n+1)/(2.*nu+1); + break; + /* // TODO NONE and XU are going to be different after all... case QPMS_NORMALISATION_XU: break; + */ default: abort(); }