From 9b9338be0544433dc6d6222a8bcc51c5b4c127df Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Ne=C4=8Dada?= Date: Sun, 5 Apr 2020 01:43:38 +0300 Subject: [PATCH] Fix critical bug in qpms_vecspharm_fill() Pointer incrementation in wrong cycle, leading to numerically completely wrong results in most cases. At higher level, this seems to have affected only plane wave decompositions. Former-commit-id: 7ebdb8b8f3f645d76e924b86379172d2c6fac8dc --- qpms/vswf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qpms/vswf.c b/qpms/vswf.c index f827364..25339d3 100644 --- a/qpms/vswf.c +++ b/qpms/vswf.c @@ -376,8 +376,8 @@ qpms_errno_t qpms_vecspharm_fill(csphvec_t *const a1target, csphvec_t *const a2t p3->phic = 0; ++p3; } + ++pleg; ++ppi; ++ptau; } - ++pleg; ++ppi; ++ptau; } qpms_pitau_free(pt); return QPMS_SUCCESS;